CZ Enhanced Feedback Module V3 Form Bug

  Post new topicReply to topicPrintable Version
<< View previous topic View next topic >>
Share: Del.icio.us  Digg  Google  Spurl  Blink  Furl  Y! MyWeb  
#1   CZ Enhanced Feedback Module V3 Form Bug
Blackcrow
CZ Newbie
 Codezwiz Site Donator
Blackcrow has been a member for over 19 year's 19 Year Member
netherlands.gif
Gender: Male
Website:
Status: Offline
Joined: May 28, 2005
0.00 posts per day
Posts: 2
Points: 1,283
   
Hi,

I installed the CZ Enhanced Feedback Module V3 on my site:
[ Register or login to view links on this board.]

and I noticed when someone just enters one field eg. Department and leaves all others blank, you could still send this feedback without receiving any errors. So I got some mails in my inbox, without department, email adresses.

I looked at the code of the modules\Feedback\index.p(h)p and found this code at line 77

    } elseif (($deptemail != "") && ($numdepts > 1) || ($fname != "") || ($email != "") || ($subject != "") || ($message != "")) {


This will cause the data to pass the verification process when any of the fields is filled in due to the use of || in the statement.

I changed the code to
    } elseif ((($deptemail != "") && ($numdepts > 1)) && ($fname != "") && ($email != "") && ($subject != "") && ($message != "")) {

And this seems to have solved the problem.

1. Could anyone please verify this?

2. Also the fields wich are filled it correctly are emptied when another field is filled in incorrectly, is there a way to leave all fields filled in and only highlight the incorrect fields?

3. I want to use the this feedback module with a help ticket system allready installed on my site, the help ticket system only accepts text messages and no Multipart messages.

Does anyone know wich code to change in the index.p(h)p $message, $header to accomplish this?

Thanks,

Blackcrow


Back to top Reply with quote
#2   
Telli
Site Admin
Occupation: Self Employed
Age: 46
Gender: Male
Fav. Sports Team: Detroit Red Wings
Website:
Status: Offline
Joined: May 26, 2003
1.03 posts per day
Posts: 8089
Points: 494,430
   
1. I cant reproduce the same error but what you have changed it should work just fine.

2. I will look and see why thats happening.




Does anyone know wich code to change in the index.p(h)p $message, $header to accomplish this?



Accomplish what?




_________________
The path of the righteous man is beset on all sides by the inequities of the selfish and the tyranny of evil men. Blessed is he, who in the name of charity and good will, shepherds the weak through the valley of darkness, for he is truly his brother's keeper and the finder of lost children. And I will strike down upon thee with great vengeance and furious anger those who would attempt to poison and destroy my brothers. And you will know my name is the Lord when I lay my vengeance upon thee. Ezekiel 25:17
Back to top Reply with quote
#3   re: CZ Enhanced Feedback Module V3 Form Bug
Blackcrow
CZ Newbie
 Codezwiz Site Donator
Blackcrow has been a member for over 19 year's 19 Year Member
netherlands.gif
Gender: Male
Website:
Status: Offline
Joined: May 28, 2005
0.00 posts per day
Posts: 2
Points: 1,283
   
Hi,

Thanks for the quick response.

Sorry for 3. got it allready working

Would be interested if you got a solution for 2. I saw this also happens on this site, so it's not a bug but more a feature request icon_smile.gif

greetz,

Blackcrow



Back to top Reply with quote
Display posts from previous:      
Add To: Del.icio.us  Digg  Google  Spurl  Blink  Furl  Y! MyWeb  
<< View previous topic View next topic >>
Post new topicReply to topic

Jump to 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum